-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for ControllerPublish and ControllerUnpublish requests #219
Add unit tests for ControllerPublish and ControllerUnpublish requests #219
Conversation
Hi @sreis. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
travis is having issue these days:
|
b270436
to
e522feb
Compare
Pull Request Test Coverage Report for Build 462
💛 - Coveralls |
@sreis could you rebase. thx |
Signed-off-by: Simão Reis <sreis@mesosphere.io>
Signed-off-by: Simão Reis <sreis@mesosphere.io>
e522feb
to
ce54c5d
Compare
@leakingtapan I've rebased PTAL. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, sreis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Increases test coverage.
What is this PR about? / Why do we need it?
Increases test coverage.
Closes #199
What testing is done?
Add unit tests for ControllerPublish and ControllerUnpublish requests.