Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New block volume e2e tests #226

Merged

Conversation

dkoshkin
Copy link
Contributor

Is this a bug fix or adding new feature?
Fixes #221

What is this PR about? / Why do we need it?
Add 2 new e2e tests that provisions block volumes.

  • a single pod with 1 block volume
  • a single pod with 1 block volume and 1 filesystem volume

What testing is done?
Locally ran the e2e tests:

• [SLOW TEST:58.178 seconds]
[ebs-csi-e2e] [single-az] Dynamic Provisioning
/Users/dkoshkin/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/dynamic_provisioning.go:35
  should create a raw block volume on demand
  /Users/dkoshkin/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/dynamic_provisioning.go:204
------------------------------
SSSSSSSSSS
Ran 1 of 32 Specs in 58.178 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 31 Skipped
PASS

Ginkgo ran 1 suite in 1m6.767981631s
Test Suite Passed

• [SLOW TEST:90.392 seconds]
[ebs-csi-e2e] [single-az] Dynamic Provisioning
/Users/dkoshkin/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/dynamic_provisioning.go:35
  should create a raw block volume and a filesystem volume on demand and bind to the same pod
  /Users/dkoshkin/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/dynamic_provisioning.go:228
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSS
Ran 1 of 32 Specs in 90.393 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 31 Skipped
PASS

Ginkgo ran 1 suite in 1m38.738854833s
Test Suite Passed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 26, 2019
@coveralls
Copy link

coveralls commented Feb 26, 2019

Pull Request Test Coverage Report for Build 481

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.773%

Totals Coverage Status
Change from base Build 478: 0.0%
Covered Lines: 980
Relevant Lines: 1446

💛 - Coveralls

@dkoshkin
Copy link
Contributor Author

dkoshkin commented Feb 26, 2019

@leakingtapan

Feb 26 12:45:19.343: INFO: At 2019-02-26 12:29:58 +0000 UTC - event for ebs-volume-tester-qh88n: {kubelet ip-172-20-56-1.us-west-2.compute.internal} FailedMapVolume: MapVolume.NewBlockVolumeMapper initialization failed for volume "pvc-116b60af-39c2-11e9-b1c6-021d115ece96" : CSIBlockVolume feature not enabled

Looks like the required feature gate is not setup in the test clusters CSIBlockVolume

Added it as part of this PR.

@dkoshkin dkoshkin force-pushed the dkoshkin/block-volume-e2e branch 2 times, most recently from 757ea0e to 90329da Compare February 26, 2019 21:47
tests/e2e/testsuites/testsuites.go Outdated Show resolved Hide resolved
tests/e2e/testsuites/specs.go Show resolved Hide resolved
tests/e2e/testsuites/specs.go Outdated Show resolved Hide resolved
tests/e2e/testsuites/testsuites.go Outdated Show resolved Hide resolved
@dkoshkin dkoshkin force-pushed the dkoshkin/block-volume-e2e branch from 90329da to d10d2ef Compare February 27, 2019 14:19
@dkoshkin dkoshkin force-pushed the dkoshkin/block-volume-e2e branch from d10d2ef to af3330f Compare February 27, 2019 15:03
@leakingtapan
Copy link
Contributor

/lgtm

@dkoshkin did you get a chance to verify the behavior of dd in busybox? will it return success even when the output file is not existing or not writable?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@dkoshkin
Copy link
Contributor Author

dkoshkin commented Feb 27, 2019

@leakingtapan yes.

➜  ~ k exec -it ebs-volume-tester-7xpc7 -n e2e-tests-ebs-q64xt sh
/ # dd if=/dev/zero of=/dev/xvda bs=1024k count=100
100+0 records in
100+0 records out
104857600 bytes (100.0MB) copied, 0.037041 seconds, 2.6GB/s
/ # echo $?
0
/ # dd if=/dev/zero of=/dev/xvdb bs=1024k count=100
dd: writing '/dev/xvdb': No space left on device
65+0 records in
64+0 records out
67108864 bytes (64.0MB) copied, 0.028264 seconds, 2.2GB/s
/ # echo $?
1

@leakingtapan
Copy link
Contributor

Thx for confirming

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkoshkin, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit c716388 into kubernetes-sigs:master Feb 27, 2019
@dkoshkin dkoshkin deleted the dkoshkin/block-volume-e2e branch February 28, 2019 17:28
dobsonj pushed a commit to dobsonj/aws-ebs-csi-driver that referenced this pull request Oct 17, 2023
…t/cherry-pick-225-to-release-4.12

[release-4.12] OCPBUGS-14281: Volume unmount repeats after successful unmount, preventing pod delete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Raw block volume e2e test
4 participants