Device allocator should not use reserved dev names.

[anusha-ragunathan]

According to
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/device_naming.html,
on HVM instances, sda1 and xvda are reserved for root partition. Also,
the available block device range for xvd follow "/dev/xvd[b-c][a-z]"
pattern.

However commit 1ace946 violates the reserved device names and the naming
logic. This causes volume attachment issues. For example, for instances
where /dev/xvda is root partition, the driver tries to create a new
device with the same reserved name.
This change fixes the issue.

Testing:
Deployed Kube 1.14 cluster.
Update manifest.yaml with canary images for sidecards and new names for
API resources.
Tested new plugin and created sc, pvc (pv) and pod.
Volume attaches to node successfully. New device attached is
"/dev/xvdba" as expected.

Pod mounts volume and runs fine.

Fixes #292

Signed-off-by: Anusha Ragunathan anusha.ragunathan@docker.com

[k8s-ci-robot]

Hi @anusha-ragunathan. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ddebroy]

/ok-to-test

[coveralls]

Pull Request Test Coverage Report for Build 637

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 71.12%

---

Totals
Change from base Build 628:	0.0%
Covered Lines:	1086
Relevant Lines:	1527

---

💛 - Coveralls

[leakingtapan]

Thx for the fix! I'm convinced starting from /dev/xvdba is the right way to go.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anusha-ragunathan, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [leakingtapan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment