Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EBS IO2 support #558

Merged
merged 2 commits into from
Sep 12, 2020
Merged

Add EBS IO2 support #558

merged 2 commits into from
Sep 12, 2020

Conversation

ayberk
Copy link
Contributor

@ayberk ayberk commented Sep 9, 2020

Is this a bug fix or adding new feature?
New feature.

What is this PR about? / Why do we need it?
This PR adds support for EBS IO2 volumes.

What testing is done?

  • Unit test
  • test-e2e-single-az

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @ayberk!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ayberk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2020
@coveralls
Copy link

coveralls commented Sep 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1195

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.934%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloud/cloud.go 0 1 0.0%
Totals Coverage Status
Change from base Build 1194: 0.0%
Covered Lines: 1446
Relevant Lines: 1809
💛 - Coveralls

@wongma7
Copy link
Contributor

wongma7 commented Sep 9, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2020
@ayberk
Copy link
Contributor Author

ayberk commented Sep 9, 2020

Failure looks unrelated. I had the same failure when I was running master locally:

[ebs-csi-e2e] [single-az] Dynamic Provisioning should create a volume on demand with volume type "sc1" and fs type "ext2" expand_less | 25m15s
-- | --
/home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/dynamic_provisioning.go:59 Unexpected error:     <*errors.errorString \| 0xc0005246e0>: {         s: "Gave up after waiting 15m0s for pod \"ebs-volume-tester-5tknk\" to be \"success or failure\"",     }     Gave up after waiting 15m0s for pod "ebs-volume-tester-5tknk" to be "success or failure" occurred /home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/testsuites/testsuites.go:552

@bertinatto
Copy link
Member

/test pull-aws-ebs-csi-driver-e2e-single-az

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2020
@ayberk
Copy link
Contributor Author

ayberk commented Sep 9, 2020

/retest

@ayberk
Copy link
Contributor Author

ayberk commented Sep 9, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

3 similar comments
@ayberk
Copy link
Contributor Author

ayberk commented Sep 9, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@ayberk
Copy link
Contributor Author

ayberk commented Sep 9, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@ayberk
Copy link
Contributor Author

ayberk commented Sep 10, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@ayberk ayberk mentioned this pull request Sep 10, 2020
Closed
@wongma7
Copy link
Contributor

wongma7 commented Sep 12, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9b33867 into kubernetes-sigs:master Sep 12, 2020
@ayberk ayberk deleted the io2 branch September 12, 2020 00:56
@ayberk ayberk mentioned this pull request Dec 7, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ayberk @k8s-ci-robot @coveralls @wongma7 @bertinatto