Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlays not being updated for gcr migration #649

Merged
merged 3 commits into from
Dec 10, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Dec 10, 2020

Is this a bug fix or adding new feature?
/bug

What is this PR about? / Why do we need it?
Fixing some oversights/neglect/mistakes from gcr migration. See: #646

What testing is done?

kubectl apply -k ./deploy/kubernetes/overlays/stable
k get deployment -n kube-system ebs-csi-controller
NAME                 READY   UP-TO-DATE   AVAILABLE   AGE
ebs-csi-controller   2/2     2            2           19d
k get deployment -n kube-system ebs-csi-controller -o jsonpath="{.spec.template.spec.containers[0].image}"
k8s.gcr.io/provider-aws/aws-ebs-csi-driver:v0.8.0^J  
kubectl apply -k ./deploy/kubernetes/overlays/dev
k get deployment -n kube-system ebs-csi-controller -o jsonpath="{.spec.template.spec.containers[0].image}"
k8s.gcr.io/provider-aws/aws-ebs-csi-driver:latest

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2020
@wongma7
Copy link
Contributor Author

wongma7 commented Dec 10, 2020

I will get this into release-0.8 brancsh also after #650 merges

@nckturner
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2020
@wongma7
Copy link
Contributor Author

wongma7 commented Dec 10, 2020

manual merge, this is not a code change!!!!

@ayberk
Copy link
Contributor

ayberk commented Dec 10, 2020

LGTM

@wongma7
Copy link
Contributor Author

wongma7 commented Dec 10, 2020

nvm I can't manual merge.

@wongma7
Copy link
Contributor Author

wongma7 commented Dec 10, 2020

merging, travis is stuck again.

considering moving all travis stuff to a prow job

@wongma7 wongma7 merged commit 63b94fb into kubernetes-sigs:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants