Prefix helm chart releases with "helm-chart-" #682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? fix #643
What is this PR about? / Why do we need it? Since chart version follows driver version but not really, to avoid confusion & ambiguity I want to prefix helm chart releases and tags with "helm-chart-". Open to suggestions of other names or references to best practices here.
What testing is done? tsted in my fork (took couple of tries):
https://github.com/wongma7/aws-ebs-csi-driver/runs/1658660168
https://github.com/wongma7/aws-ebs-csi-driver/releases/tag/helm-chart-aws-ebs-csi-driver-0.7.4