-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add toleration time to NoExecute effect #775
add toleration time to NoExecute effect #775
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndyXiangLi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-aws-ebs-csi-driver-verify |
Pull Request Test Coverage Report for Build 1671
💛 - Coveralls |
089e34b
to
4e994c2
Compare
/test pull-aws-ebs-csi-driver-verify |
/test pull-aws-ebs-csi-driver-unit |
I would prefer we stop tolerating NoSchedule. #758 (comment) |
4e994c2
to
b26c975
Compare
@AndyXiangLi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
close this PR to address unit test issue, will reopen it later. |
/close |
@AndyXiangLi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a bug fix or adding new feature?
Fixes #588
What is this PR about? / Why do we need it?
Distinct two types of tolerations and add default 300s tolerationSeconds to all the NoExecute taints.