-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to read subpath from volume handle #102
Conversation
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Any progress on this issue? |
@skang0601 thx for the follow up. I still need to add some unit tests for the new code added. After coverage is back up, you should be good to go |
Add unit test
e689d28
to
729255b
Compare
729255b
to
edbd75f
Compare
Is this a bug fix or adding new feature?
Update to read subpath from volume handle
Fixes: #100
Tested manually with following specs and verified it works: