Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old TravisCI config file #1129

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

jacobwolfaws
Copy link

PR feedback

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
cleaning up the driver, references to travis & testing coverage that are no longer valid
Rebased the commits from this PR: #978. All credit goes to asherf
What testing is done?

Signed-off-by: Asher Foa <1268088+asherf@users.noreply.github.com>

PR feedback
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2023
@mskanth972
Copy link
Contributor

Thanks @asherf and @jacobwolfaws for the PR.

@mskanth972
Copy link
Contributor

/approve

@mskanth972
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobwolfaws, mskanth972

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@torredil
Copy link
Member

/test pull-aws-efs-csi-driver-external-test-eks

1 similar comment
@mskanth972
Copy link
Contributor

/test pull-aws-efs-csi-driver-external-test-eks

@k8s-ci-robot k8s-ci-robot merged commit 07cda5f into kubernetes-sigs:master Sep 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants