Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover EFS FileSystemId instead of specifying it in storage class #1492

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

avanish23
Copy link
Contributor

@avanish23 avanish23 commented Nov 1, 2024

What is this PR about? / Why do we need it?
This PR introduces the feature of discovering EFS FileSystemId instead of having to specify it in the SC parameters.
The way to use this feature is to create a storage class where the parameters have a new field fileSystemDiscovery.
Currently, it takes 2 fields creationToken and tags both being optional.
creationToken is a string that takes the creation token of the EFS to be discovered as input
tags is a map of strings
Sample Storage Class

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: efs-sc
provisioner: efs.csi.aws.com
parameters:
  provisioningMode: efs-ap
  directoryPerms: "700"
  gidRangeStart: "1000" # optional
  gidRangeEnd: "2000" # optional
  basePath: "/dynamic_provisioning" # optional
  subPathPattern: "${.PVC.namespace}/${.PVC.name}" # optional
  ensureUniqueDirectory: "true" # optional
  reuseAccessPoint: "false" # optional
  fileSystemDiscovery: |
    creationToken: aws-efs-for-discovery
    tags:
      env: prod
      owner: avanishpatil23@gmail.com

Note:

  • use EFS Discovery with | as it is a multi-line string input
  • fileSystemId will continue to be supported as a parameter
  • if more than one EFS is discovered, the driver will throw an error; likewise, if no EFS is discovered
  • the EFS discovery results are not cached

What testing is done?
Unit tests added and current unit tests pass

Closes #1052

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avanish23
Once this PR has been reviewed and has the lgtm label, please assign d-nishi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 1, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @avanish23. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 1, 2024
discovering efs with tags support

add new mocks

added mount_utils interface to the MockMounter

discovering efs with single AWS call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover EFS fileSystemId / volumeHandle instead of specifying it
2 participants