Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s dependencies to 1.17.6 #174

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Bump k8s dependencies to 1.17.6 #174

merged 2 commits into from
Jun 3, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jun 1, 2020

Is this a bug fix or adding new feature? fix

What is this PR about? / Why do we need it? Routine bump of dependencies. Only thing of note is that k8s.io/utils/mount is now out of k8s.io/kubernetes

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 1, 2020
@jqmichael
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jqmichael: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2020
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 2, 2020

need to also bump test cluster version (#151) as by bumping the deps to 1.17 we picked up a test that only makes sense when run against 1.17 clusters (volumeMode should not mount / map unused volumes in a pod)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2020
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 2, 2020

need aws/aws-k8s-tester#88 i think

@wongma7
Copy link
Contributor Author

wongma7 commented Jun 2, 2020

/test pull-aws-efs-csi-driver-e2e

1 similar comment
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 2, 2020

/test pull-aws-efs-csi-driver-e2e

@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit ad02e03 into kubernetes-sigs:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@nckturner nckturner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wongma7 @k8s-ci-robot @jqmichael @nckturner