Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify command #424

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

buptliuwei
Copy link
Contributor

@buptliuwei buptliuwei commented Apr 25, 2021

The file in the mountpath in the pod is out instead of out.txt

[root@efs-app /]# ls
bin  data  dev	etc  home  lib	lib64  lost+found  media  mnt  opt  proc  root	run  sbin  srv	sys  tmp  usr  var
[root@efs-app /]# cd data
[root@efs-app data]# ls
out
[root@efs-app data]# pwd
/data
[root@efs-app data]#

$ kubectl exec -ti efs-app -- tail -f /data/out.txt
tail: cannot open '/data/out.txt' for reading: No such file or directory
tail: no files remaining
command terminated with exit code 1
$ kubectl exec -ti efs-app -- tail -f /data/out
Sun Apr 25 11:59:59 UTC 2021
Sun Apr 25 12:00:04 UTC 2021
Sun Apr 25 12:00:09 UTC 2021
Sun Apr 25 12:00:14 UTC 2021

Is this a bug fix or adding new feature?
/bug fix
What is this PR about? / Why do we need it?
/doc /update readme
What testing is done?
Verify locally

The file in the mountpath in the pod is `out` instead of `out.txt`
```bash
[root@efs-app /]# ls
bin  data  dev	etc  home  lib	lib64  lost+found  media  mnt  opt  proc  root	run  sbin  srv	sys  tmp  usr  var
[root@efs-app /]# cd data
[root@efs-app data]# ls
out
[root@efs-app data]# pwd
/data
[root@efs-app data]#

$ kubectl exec -ti efs-app -- tail -f /data/out.txt
tail: cannot open '/data/out.txt' for reading: No such file or directory
tail: no files remaining
command terminated with exit code 1
$ kubectl exec -ti efs-app -- tail -f /data/out
Sun Apr 25 11:59:59 UTC 2021
Sun Apr 25 12:00:04 UTC 2021
Sun Apr 25 12:00:09 UTC 2021
Sun Apr 25 12:00:14 UTC 2021
```
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @buptliuwei!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @buptliuwei. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2021
@buptliuwei
Copy link
Contributor Author

/assign @d-nishi

@wongma7
Copy link
Contributor

wongma7 commented Apr 26, 2021

/lgtm
/approve

thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptliuwei, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit ba2b561 into kubernetes-sigs:master Apr 26, 2021
@buptliuwei buptliuwei deleted the patch-1 branch April 27, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants