Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update access point root directory name to use PV name #448

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

kbasv
Copy link

@kbasv kbasv commented May 13, 2021

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
Access point root directory name will be created with PV name. This makes it easy to track access point associated with a PV .

What testing is done?

Tested on EKS cluster.

Before this change, AP root directory looks like:

efs-csi-ap-1000-72f94a19-4f91-46c0-bd7b-d7acde1d969c

After applying this change, AP root directory looks like:

pvc-0af3bcf3-6f60-4164-8055-88466a239624

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2021
@kbasv kbasv changed the title Update access point root directory name to use pvc name Update access point root directory name to use PV name May 13, 2021
@wongma7
Copy link
Contributor

wongma7 commented Jun 2, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbasv, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wongma7 wongma7 merged commit c1e3f9f into kubernetes-sigs:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants