-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put comments back in place inside the values file #475
Put comments back in place inside the values file #475
Conversation
Welcome @pierluigilenoci! |
Hi @pierluigilenoci. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierluigilenoci, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Not really a bug fix but it corrects a problem inside the chart value file.
Ref: 008332a#diff-56338152bc066c1274cc12e455c5d0585a0ce0cb30831547f47a758d2a750862L78-L80
What is this PR about? / Why do we need it?
The commented example has been moved to the wrong place.
Can be confusing for anyone who wants to use the annotation.
What testing is done?
None, just a moved comments.