-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally added AWS_STS_REGIONAL_ENDPOINTS flag #585
Conditionally added AWS_STS_REGIONAL_ENDPOINTS flag #585
Conversation
Welcome @holmesb! |
Hi @holmesb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is anyone able to review this? Probably fixes issues #555 & #499 |
/ok-to-test |
…fs-plugin container. Is needed to create persistent volumes on private EKS clusters. Without this, dynamic pv creation errors: "Failed to fetch File System info: Describe File System failed"
a54f93b
to
59757e3
Compare
Fixed merge conflict @wongma7 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lgtm apologies for super long review time, I did another merge/rebase via github ui |
/remove-lifecycle stale |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: holmesb, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
to controller's efs-plugin container. Is needed to create persistent volumes on private EKS clusters. Without this, dynamic pv creation errors: "Failed to fetch File System info: Describe File System failed"
Is this a bug fix or adding new feature?
new feature (adds support for private eks clusters)