Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: fix non-existing k8s.io/kubernetes version #645

Merged
merged 1 commit into from
Mar 15, 2022
Merged

go.mod: fix non-existing k8s.io/kubernetes version #645

merged 1 commit into from
Mar 15, 2022

Conversation

bertinatto
Copy link
Member

Builds based on the release-1.3 branch are currently failing. The reason is an incorrect dependency version:

$ go mod tidy
go: downloading k8s.io/kubernetes v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/pkg/driver imports
	k8s.io/kubernetes/pkg/volume/util/fs: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e imports
	k8s.io/kubernetes/test/e2e/framework: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e imports
	k8s.io/kubernetes/test/e2e/framework/node: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e imports
	k8s.io/kubernetes/test/e2e/framework/pod: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e imports
	k8s.io/kubernetes/test/e2e/storage/testpatterns: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e imports
	k8s.io/kubernetes/test/e2e/storage/testsuites: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e imports
	k8s.io/kubernetes/test/e2e/storage/utils: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e tested by
	github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e.test imports
	k8s.io/kubernetes/test/e2e/framework/config: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e tested by
	github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e.test imports
	k8s.io/kubernetes/test/e2e/framework/testfiles: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/pkg/driver imports
	google.golang.org/grpc tested by
	google.golang.org/grpc.test imports
	google.golang.org/grpc/grpclog/glogger imports
	github.com/golang/glog: k8s.io/kubernetes@v1.23.10: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/pkg/driver imports
	k8s.io/utils/mount imports
	k8s.io/utils/path tested by
	k8s.io/utils/path.test imports
	github.com/spf13/afero: k8s.io/kubernetes@v1.23.10: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10
github.com/kubernetes-sigs/aws-efs-csi-driver/pkg/driver tested by
	github.com/kubernetes-sigs/aws-efs-csi-driver/pkg/driver.test imports
	github.com/kubernetes-csi/csi-test/pkg/sanity imports
	gopkg.in/yaml.v2 tested by
	gopkg.in/yaml.v2.test imports
	gopkg.in/check.v1: k8s.io/kubernetes@v1.23.10: reading k8s.io/kubernetes/go.mod at revision v1.23.10: unknown revision v1.23.10

Version v1.23.10 doesn't exist yet. This patch reverts the k8s.io/kubernetes version to v1.18.10, which is the version pinned in all the other k8s dependencies.

@bertinatto
go.mod: fix non-existing k8s.io/kubernetes version
56ca140 
Version v1.23.10 doesn't exist yet. This patch reverts
the k8s.io/kubernetes version to v1.18.10, which is the
version pinned in all the other k8s dependencies.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2022
@bertinatto
Copy link
Member Author

/assign @wongma7

@wongma7
Copy link
Contributor

wongma7 commented Mar 15, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit c612aae into kubernetes-sigs:release-1.3 Mar 15, 2022
@joepvd joepvd mentioned this pull request Mar 16, 2022
Merged
@bertinatto bertinatto mentioned this pull request May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@kbasv kbasv Awaiting requested review from kbasv

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertinatto @wongma7 @k8s-ci-robot