Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k8s and eksctl version for Test cluster failure fix #987

Conversation

Ashley-wenyizha
Copy link
Contributor

Is this a bug fix or adding new feature?
Upgrade k8s and eksctl version for Test cluster failure fix
What is this PR about? / Why do we need it?

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2023
@mskanth972
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@mskanth972
Copy link
Contributor

/retest

hack/e2e/run.sh Outdated

KOPS_VERSION=${KOPS_VERSION:-1.21.0}
KOPS_VERSION=${KOPS_VERSION:-1.23.3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this match the version of the cluster? I didn't before, so as long as the tests pass, maybe we're fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep good catch, this should match, revised

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is the reason, looking at why efs-utils is not able to install

 #0 9.560 Error: Package: rpm-build-4.11.3-48.amzn2.0.2.x86_64 (amzn2-core)
#0 9.560            Requires: rpm = 4.11.3-48.amzn2.0.2
#0 9.560            Installed: rpm-4.11.3-48.amzn2.0.3.x86_64 (installed)
#0 9.560                rpm = 4.11.3-48.amzn2.0.3
#0 9.560            Available: rpm-4.11.3-25.amzn2.0.1.x86_64 (amzn2-core)
#0 9.560                rpm = 4.11.3-25.amzn2.0.1
#0 9.560            Available: rpm-4.11.3-25.amzn2.0.3.x86_64 (amzn2-core)
#0 9.560                rpm = 4.11.3-25.amzn2.0.3
#0 9.560            Available: rpm-4.11.3-40.amzn2.0.3.x86_64 (amzn2-core)
#0 9.560                rpm = 4.11.3-40.amzn2.0.3
#0 9.560            Available: rpm-4.11.3-40.amzn2.0.4.x86_64 (amzn2-core)
#0 9.560                rpm = 4.11.3-40.amzn2.0.4
#0 9.560            Available: rpm-4.11.3-40.amzn2.0.5.x86_64 (amzn2-core)
#0 9.560                rpm = 4.11.3-40.amzn2.0.5
#0 9.560            Available: rpm-4.11.3-40.amzn2.0.6.x86_64 (amzn2-core)
#0 9.560                rpm = 4.11.3-40.amzn2.0.6
#0 9.560            Available: rpm-4.11.3-48.amzn2.0.2.x86_64 (amzn2-core)
#0 9.560                rpm = 4.11.3-48.amzn2.0.2
#0 9.560  You could try using --skip-broken to work around the problem
#0 9.633 ** Found 2 pre-existing rpmdb problem(s), 'yum check' output follows:
#0 9.633 ca-certificates-2021.2.50-72.amzn2.0.5.noarch has missing requires of p11-kit >= ('0', '0.23.5', None)
#0 9.633 ca-certificates-2021.2.50-72.amzn2.0.5.noarch has missing requires of p11-kit-trust >= ('0', '0.23.5', None)
#13 ERROR: process "/bin/sh -c mkdir -p /tmp/rpms &&     if [ \"$EFSUTILSSOURCE\" = \"yum\" ];     then echo \"Installing efs-utils from Amazon Linux 2 yum repo\" &&          yum -y install --downloadonly --downloaddir=/tmp/rpms amazon-efs-utils-1.34.4-1.amzn2.noarch;     else echo \"Installing efs-utils from github using the latest git tag\" &&          yum -y install git rpm-build make &&          git clone https://github.com/aws/efs-utils &&          cd efs-utils &&          git checkout $(git describe --tags $(git rev-list --tags --max-count=1)) &&          make rpm && mv build/amazon-efs-utils*rpm /tmp/rpms &&          cd .. && rm -rf efs-utils &&          yum clean all;     fi" did not complete successfully: exit code: 1 

I dont see a straight correlation there

@Ashley-wenyizha
Copy link
Contributor Author

/retest

1 similar comment
@Ashley-wenyizha
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2023
@mskanth972
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@mskanth972
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ashley-wenyizha, mskanth972, RyanStan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Ashley-wenyizha,mskanth972]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f5ce6d6 into kubernetes-sigs:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants