Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module dependencies #2998

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Update module dependencies #2998

merged 1 commit into from
Jan 25, 2023

Conversation

johngmyers
Copy link
Contributor

Issue

N/A

Description

Updates the remaining module dependencies, making changes as necessary for the incompatible changes in go-logr.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2023
@johngmyers
Copy link
Contributor Author

/retest

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@kishorj
Copy link
Collaborator

kishorj commented Jan 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit c94ffd3 into kubernetes-sigs:main Jan 25, 2023
@johngmyers johngmyers deleted the upgrade-logr branch January 26, 2023 04:03
@kishorj kishorj mentioned this pull request Feb 17, 2023
Closed
@johngmyers johngmyers mentioned this pull request Feb 18, 2023
Merged
6 tasks
@rodrigorfk rodrigorfk mentioned this pull request Mar 23, 2023
Closed
This was referenced Apr 14, 2023
Closed
Merged
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@johngmyers @Timothy-Dougherty
Update module dependencies (kubernetes-sigs#2998)
d48b683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj approved these changes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@kishorj kishorj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johngmyers @k8s-ci-robot @kishorj