Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to discovery.k8s.io/v1 #3072

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

kishorj
Copy link
Collaborator

@kishorj kishorj commented Feb 22, 2023

Issue

Fixes: #3071

Description

Controller uses discovery.k8s.io/v1beta1, which is not supported starting k8s v1.25 release. This PR updates the controller to use discovery.k8s.io/v1. As a result, the controller will no longer support k8s 1.20 or earlier release if EndpointSlices feature is enabled via the controller flag.

Manual tests:

  • verify controller is functional on 1.24 cluster with --enable-endpoint-slices=true, ALB with IP targets get provisioned as expected
  • works as expected when endpoint slices disabled
  • verify controller is functional on k8s 1.26, successfully provisions ALB with IP targets. Previous version of the controller was non-functional with the endpoint slices enabled

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

$ ag "k8s.io/api/discovery/v1beta1" -l
controllers/elbv2/targetgroupbinding_controller.go
controllers/elbv2/eventhandlers/endpointslices_test.go
controllers/elbv2/eventhandlers/endpointslices.go
pkg/backend/endpoint_types.go
pkg/backend/endpoint_resolver_test.go
pkg/backend/endpoint_resolver.go

In the main branch.

@codecov-commenter
Copy link

Codecov Report

Base: 54.32% // Head: 54.34% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (7cd00c8) compared to base (fd429b7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3072      +/-   ##
==========================================
+ Coverage   54.32%   54.34%   +0.02%     
==========================================
  Files         145      145              
  Lines        8410     8427      +17     
==========================================
+ Hits         4569     4580      +11     
- Misses       3511     3516       +5     
- Partials      330      331       +1     
Impacted Files Coverage Δ
pkg/backend/endpoint_resolver.go 86.41% <ø> (ø)
pkg/backend/endpoint_types.go 100.00% <ø> (ø)
webhooks/networking/ingress_validator.go 62.92% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 22, 2023
@kishorj kishorj marked this pull request as ready for review February 22, 2023 23:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2023
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh, orsenthil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 381349d into kubernetes-sigs:main Feb 23, 2023
@kishorj kishorj deleted the discv1-update branch March 23, 2023 22:41
johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Aug 21, 2023
Merge in DEL/aws-load-balancer-controller-fork from DELIVERY-8202_pull_upstream to main

* commit '49805eac72ec533acdbc2580d6f57c68a9cad45c':
  update the default base image (kubernetes-sigs#3075)
  update recommended IAM policy template (kubernetes-sigs#3068)
  update to discovery.k8s.io/v1 (kubernetes-sigs#3072)
  validation ingress condition annotation in validation webhook (kubernetes-sigs#2735)
  Fix conciseLogger's incorrect call to variadic func (kubernetes-sigs#3066)
  Verify CRDs are up to date in merge check (kubernetes-sigs#3022)
  Refactor model builder test (kubernetes-sigs#3024)
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS LB Controller with EndpointSlices enabled not compatible with Kubernetes v1.25
5 participants