-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update prow script #3406
update prow script #3406
Conversation
9e12b7f
to
cc860d0
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3406 +/- ##
=======================================
Coverage 55.76% 55.76%
=======================================
Files 149 149
Lines 8827 8827
=======================================
Hits 4922 4922
Misses 3571 3571
Partials 334 334 ☔ View full report in Codecov by Sentry. |
5684ee6
to
5bc41ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
* update prow script * add step to create ingressclass and params
Issue
Description
update the script for a discrepancy in
sed
command for AL2 env. Add the creations of ingressclass and ingressclassparams.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯