improve the enable primary ipv6 address and TEST_ID in prow script #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
jaydeokar
reviewed
Jan 3, 2024
jaydeokar
approved these changes
Jan 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3524 +/- ##
=======================================
Coverage 55.75% 55.75%
=======================================
Files 149 149
Lines 8843 8843
=======================================
Hits 4930 4930
Misses 3579 3579
Partials 334 334 ☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
size/S
jaydeokar
approved these changes
Jan 3, 2024
oliviassss
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaydeokar, M00nF1sh, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
johngmyers
pushed a commit
to johngmyers/aws-load-balancer-controller
that referenced
this pull request
Feb 6, 2024
…ubernetes-sigs#3524) * improve the enable primary ipv6 address and TEST_ID in prow script * bump up IngressDNSAvailableWaitTimeout to tolerate the timeout in prow * bump up go version to 1.21.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
This PR bumps up the go version to 1.21.5 and also improves and fixes the prow script by -
--regionparam, and also log lines in enable_primary_ipv6_address()IngressDNSAvailableWaitTimeoutfrom 3min to 5min to tolerate the timeout issue in prowChecklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯