Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log level in listener manager and tagging manager #3573

Merged
merged 1 commit into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/deploy/elbv2/listener_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func (m *defaultListenerManager) updateSDKListenerWithExtraCertificates(ctx cont
sdkLS ListenerWithTags, isNewSDKListener bool) error {
// if TLS is not supported, we shouldn't update
if resLS.Spec.SSLPolicy == nil && sdkLS.Listener.SslPolicy == nil {
m.logger.V(2).Info("Res and Sdk Listener don't have SSL Policy set, we skip updating extra certs for non-TLS listener.")
m.logger.V(1).Info("Res and Sdk Listener don't have SSL Policy set, skip updating extra certs for non-TLS listener.")
return nil
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/deploy/elbv2/tagging_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,15 +259,15 @@ func (m *defaultTaggingManager) ListListenerRules(ctx context.Context, lsARN str
// TODO: we can refactor this by store provisioned LB's ARN as annotations on Ingress/Service, thus avoid this heavy lookup calls when RGT is not available.
func (m *defaultTaggingManager) ListLoadBalancers(ctx context.Context, tagFilters ...tracking.TagFilter) ([]LoadBalancerWithTags, error) {
if m.featureGates.Enabled(config.EnableRGTAPI) {
m.logger.V(2).Info("ResourceGroupTagging enabled, list the load balancers via RGT API")
m.logger.V(1).Info("ResourceGroupTagging enabled, list the load balancers via RGT API")
return m.listLoadBalancersRGT(ctx, tagFilters)
}
return m.listLoadBalancersNative(ctx, tagFilters)
}

func (m *defaultTaggingManager) ListTargetGroups(ctx context.Context, tagFilters ...tracking.TagFilter) ([]TargetGroupWithTags, error) {
if m.featureGates.Enabled(config.EnableRGTAPI) {
m.logger.V(2).Info("ResourceGroupTagging enabled, list the target groups via RGT API")
m.logger.V(1).Info("ResourceGroupTagging enabled, list the target groups via RGT API")
return m.listTargetGroupsRGT(ctx, tagFilters)
}
return m.listTargetGroupsNative(ctx, tagFilters)
Expand Down
Loading