Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ReadWriteOncePod cap #517

Merged
merged 2 commits into from
Sep 22, 2021
Merged

feat: add ReadWriteOncePod cap #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eec5513
feat: add ReadWriteOncePod cap
andyzhangx Sep 21, 2021
dd6f13c
chore: fix docker build
andyzhangx Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ blob-darwin:

.PHONY: container
container: blob
docker build -t $(IMAGE_TAG) -f ./pkg/blobplugin/dev.Dockerfile .
docker build -t $(IMAGE_TAG) --output=type=docker -f ./pkg/blobplugin/dev.Dockerfile .

.PHONY: container-linux
container-linux:
Expand Down
3 changes: 2 additions & 1 deletion pkg/blob/blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ func (d *Driver) Run(endpoint, kubeconfig string, testBool bool) {
//csi.ControllerServiceCapability_RPC_CREATE_DELETE_SNAPSHOT,
//csi.ControllerServiceCapability_RPC_LIST_SNAPSHOTS,
csi.ControllerServiceCapability_RPC_EXPAND_VOLUME,
csi.ControllerServiceCapability_RPC_SINGLE_NODE_MULTI_WRITER,
})
d.AddVolumeCapabilityAccessModes([]csi.VolumeCapability_AccessMode_Mode{
csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER,
Expand All @@ -202,7 +203,7 @@ func (d *Driver) Run(endpoint, kubeconfig string, testBool bool) {
d.AddNodeServiceCapabilities([]csi.NodeServiceCapability_RPC_Type{
csi.NodeServiceCapability_RPC_STAGE_UNSTAGE_VOLUME,
csi.NodeServiceCapability_RPC_GET_VOLUME_STATS,
csi.NodeServiceCapability_RPC_UNKNOWN,
csi.NodeServiceCapability_RPC_SINGLE_NODE_MULTI_WRITER,
})

s := csicommon.NewNonBlockingGRPCServer()
Expand Down
2 changes: 1 addition & 1 deletion test/sanity/run-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ _output/blobplugin --endpoint "$nodeendpoint" --nodeid "$nodeid" --enable-blob-m

echo "Begin to run sanity test..."
readonly CSI_SANITY_BIN='csi-sanity'
"$CSI_SANITY_BIN" --ginkgo.v --csi.endpoint=$nodeendpoint --csi.controllerendpoint=$controllerendpoint -ginkgo.skip="should fail when requesting to create a volume with already existing name and different capacity|should be idempotent"
"$CSI_SANITY_BIN" --ginkgo.v --csi.endpoint=$nodeendpoint --csi.controllerendpoint=$controllerendpoint -ginkgo.skip="should fail when requesting to create a volume with already existing name and different capacity|should be idempotent|should return appropriate capabilities"