Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: secret namespace searching issue #528

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 2, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: secret namespace searching issue
if node identity does not have permission to list storage account key, it would fail to mount, this PR fixed the issue.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

I1001 15:34:44.671778       1 utils.go:114] GRPC call: /csi.v1.Node/NodeStageVolume
I1001 15:34:44.671797       1 utils.go:115] GRPC request: {"staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/pv/blob-694-blob.csi.azure.com-preprovsioned-pv-4wzwn/globalmount","volume_capability":{"AccessType":{"Mount":{}},"access_mode":{"mode":5}},"volume_id":"kubetest-rimgvzsp#fused9a41945a0154b6fbfd#pre-provisioned-multiple-pods1633102415563718032#pre-provisioned-multiple-pods1633102415563718032"}
I1001 15:34:44.671897       1 blob.go:327] volumeID(kubetest-rimgvzsp#fused9a41945a0154b6fbfd#pre-provisioned-multiple-pods1633102415563718032#pre-provisioned-multiple-pods1633102415563718032) authEnv: []
I1001 15:34:44.678140       1 round_trippers.go:454] GET https://10.0.0.1:443/api/v1/namespaces/default/secrets/azure-storage-account-fused9a41945a0154b6fbfd-secret 404 Not Found in 6 milliseconds
I1001 15:34:44.678227       1 blob.go:370] get account(fused9a41945a0154b6fbfd) key from secret(default, azure-storage-account-fused9a41945a0154b6fbfd-secret) failed with error: could not get secret(azure-storage-account-fused9a41945a0154b6fbfd-secret): secrets "azure-storage-account-fused9a41945a0154b6fbfd-secret" not found, use cluster identity to get account key instead
I1001 15:34:44.740101       1 nodeserver.go:289] target /var/lib/kubelet/plugins/kubernetes.io/csi/pv/blob-694-blob.csi.azure.com-preprovsioned-pv-4wzwn/globalmount
protocol

volumeId kubetest-rimgvzsp#fused9a41945a0154b6fbfd#pre-provisioned-multiple-pods1633102415563718032#pre-provisioned-multiple-pods1633102415563718032
context map[]
mountflags []
mountOptions [--tmp-path=/mnt/kubetest-rimgvzsp#fused9a41945a0154b6fbfd#pre-provisioned-multiple-pods1633102415563718032#pre-provisioned-multiple-pods1633102415563718032#1633102484 --container-name=pre-provisioned-multiple-pods1633102415563718032 --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=60]
args /var/lib/kubelet/plugins/kubernetes.io/csi/pv/blob-694-blob.csi.azure.com-preprovsioned-pv-4wzwn/globalmount --tmp-path=/mnt/kubetest-rimgvzsp#fused9a41945a0154b6fbfd#pre-provisioned-multiple-pods1633102415563718032#pre-provisioned-multiple-pods1633102415563718032#1633102484 --container-name=pre-provisioned-multiple-pods1633102415563718032 --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=60
I1001 15:34:44.740144       1 nodeserver.go:129] mouting using blobfuse proxy
I1001 15:34:44.740699       1 nodeserver.go:142] calling BlobfuseProxy: MountAzureBlob function
E1001 15:34:44.841275       1 nodeserver.go:145] GRPC call returned with an error:rpc error: code = Unknown desc = exit status 1
E1001 15:34:44.841310       1 nodeserver.go:311] Mount failed with error: rpc error: code = Unknown desc = exit status 1, output:
E1001 15:34:44.841414       1 utils.go:119] GRPC error: Mount failed with error: rpc error: code = Unknown desc = exit status 1, output:


Oct 01 15:32:19 k8s-agentpool1-13157012-1 blobfuse-proxy[6463]: I1001 15:32:19.669420    6463 server.go:53] received mount request: Mounting with args /var/lib/kubelet/plugins/kubernetes.io/csi/pv/blob-8081-blob.csi.azure.com-preprovsioned-pv-s8fx9/globalmount --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=60 --tmp-path=/mnt/kubetest-rimgvzsp#fused9a41945a0154b6fbfd#pre-provisioned-readonly#pre-provisioned-readonly#1633102339 --container-name=pre-provisioned-readonly
Oct 01 15:32:19 k8s-agentpool1-13157012-1 blobfuse-proxy[6463]: E1001 15:32:19.745407    6463 server.go:61] blobfuse mount failed: with error:exit status 1
Oct 01 15:32:19 k8s-agentpool1-13157012-1 blobfuse-proxy[6463]: I1001 15:32:19.745663    6463 server.go:66] blobfuse output: fuse: unknown option `--pre-mount-validate=true'

Release note:

fix: secret namespace searching issue

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2021
@andyzhangx
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2021
@andyzhangx andyzhangx merged commit 03eb784 into kubernetes-sigs:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants