Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NodePublishVolume idempotent issue and add a test case #615

Merged
merged 5 commits into from
Feb 18, 2022

Conversation

chyin6
Copy link
Contributor

@chyin6 chyin6 commented Feb 17, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

NodePublishVolume need to be idempotent. Currently NodePublishVolume will mount a volume to the same mountpoint repeatedly when it's called with the same parameters multiply time. This may happen when CO encounter some failures. Such as, when NodePublishVolume is called but timeout, CO will call it with same parameters again.

run this can repo this issue.

sudo  go test -v -timeout 30s -run ^TestNodePublishVolumeIdempotentMount$ sigs.k8s.io/blob-csi-driver/pkg/blob

This issue mainly due to IsLikelyNotMountPoint can't handle bind mount. See IsLikelyNotMountPoint doc. So, list all the mount points to confirm the mountpoint exists or not.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: NodePublishVolume idempotent issue

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @fuxiuyin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2022
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2022
@chyin6
Copy link
Contributor Author

chyin6 commented Feb 18, 2022

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, fuxiuyin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@andyzhangx andyzhangx merged commit d93744f into kubernetes-sigs:master Feb 18, 2022
@andyzhangx andyzhangx changed the title fix: nodepublishvolume idempotent issue and add a test case fix: NodePublishVolume idempotent issue and add a test case Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants