-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NodePublishVolume idempotent issue and add a test case #615
Conversation
Hi @fuxiuyin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, fuxiuyin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
NodePublishVolume need to be idempotent. Currently NodePublishVolume will mount a volume to the same mountpoint repeatedly when it's called with the same parameters multiply time. This may happen when CO encounter some failures. Such as, when NodePublishVolume is called but timeout, CO will call it with same parameters again.
run this can repo this issue.
sudo go test -v -timeout 30s -run ^TestNodePublishVolumeIdempotentMount$ sigs.k8s.io/blob-csi-driver/pkg/blob
This issue mainly due to
IsLikelyNotMountPoint
can't handle bind mount. See IsLikelyNotMountPoint doc. So, list all the mount points to confirm the mountpoint exists or not.Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: