Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: combine blobfuse-proxy daemonset with driver node daemonset #691

Merged
merged 1 commit into from
Jun 13, 2022
Merged

feat: combine blobfuse-proxy daemonset with driver node daemonset #691

merged 1 commit into from
Jun 13, 2022

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Jun 9, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
No need a standalone daemonset for blobfuse-proxy. Change blobfuse-proxy from daemonset to initContainer.

Which issue(s) this PR fixes:

Fixes #692

Requirements:

Special notes for your reviewer:

Other changes includes:

  1. Change the way to install blobfuse-proxy from using deb package manager to binary installation.

Release note:

Change blobfuse-proxy from daemonset to initContainer

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 9, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cvvz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022
@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2022
@andyzhangx
Copy link
Member 

Error: INSTALLATION FAILED: YAML parse error on blob-csi-driver/templates/csi-blob-node.yaml: error converting YAML to JSON: yaml: line 54: did not find expected '-' indicator

@cvvz
Copy link
Member Author

cvvz commented Jun 10, 2022

Helm charts errors fixed and test manually.

andyzhangx
andyzhangx reviewed Jun 10, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest chart config has changed, pls run "helm package charts/latest/blob-csi-driver -d charts/latest/" to update tgz file

build/blobplugin/Dockerfile Outdated Show resolved Hide resolved
pkg/blobfuse-proxy/debpackage/DEBIAN/control Show resolved Hide resolved
charts/latest/blob-csi-driver/templates/csi-blob-node.yaml Outdated Show resolved Hide resolved
@andyzhangx andyzhangx changed the title Change blobfuse-proxy from daemonset to initContainer feat: combine blobfuse-proxy daemonset with driver node daemonset Jun 10, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 13, 2022
@andyzhangx
Copy link
Member

latest chart config has changed, pls run "helm package charts/latest/blob-csi-driver -d charts/latest/" to update tgz file

@cvvz
Copy link
Member Author

cvvz commented Jun 13, 2022

tgz file updated

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 13, 2022
@andyzhangx
Copy link
Member

/retest

andyzhangx
andyzhangx approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit e95db52 into kubernetes-sigs:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No need to use daemonset to install and start blobfuse-proxy
3 participants
@cvvz @k8s-ci-robot @andyzhangx