Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 add first draft of AWS multitenancy proposal (#1552) #1674

Closed
wants to merge 2 commits into from
Closed

📖 add first draft of AWS multitenancy proposal (#1552) #1674

wants to merge 2 commits into from

Conversation

andrewmyhre
Copy link
Contributor

@andrewmyhre andrewmyhre commented Mar 30, 2020 •
edited by randomvariable
Loading

What this PR does / why we need it: Enable CAPA to reconcile Kubernetes clusters in a multi-tenant/VPC sharing architecture

Which issue(s) this PR fixes :
Partial resolution of #1552

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @andrewmyhre. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewmyhre
To complete the pull request process, please assign luxas
You can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from rudoi and vincepri March 30, 2020 20:40
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 30, 2020
@randomvariable
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
randomvariable
randomvariable reviewed Apr 1, 2020
View reviewed changes
docs/proposal/aws-multitenancy.md
metadata:
name: my-cluster
spec:
iamRoleArn: arn:aws:iam::123456789:role/CAPARole
Copy link
Member

@randomvariable randomvariable Apr 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only adding IAM role ARN introduces a confused deputy risk, which is important for some of our users. Would need to support external ID as well, which ideally would be stored separately in a secret to protect what is esentially a pseudo-shared secret.

@randomvariable
Copy link
Member

randomvariable commented Apr 1, 2020 •
edited
Loading

I'm just going through some docs, and ensuring we can cover the various permutations. Will update tomorrow.

@randomvariable
Copy link
Member

Hi @andrewmyhre :

I've created a Google Doc with proposed changes here:
https://docs.google.com/document/d/1vwjvWc-RIZfwDXb-3tW4gKBOaPCKhripfhXshOmB5z4/edit#

This covers additional use cases important for some of our users, especially around hiding confidential aspects of credentials and caching.

@vincepri vincepri marked this pull request as draft May 1, 2020 18:20
@randomvariable randomvariable mentioned this pull request May 6, 2020
Merged
@randomvariable
Copy link
Member

Let's rally in #1713 if that's ok?
Closing for now.

@devigned devigned mentioned this pull request Jul 20, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomvariable randomvariable randomvariable left review comments

@rudoi rudoi Awaiting requested review from rudoi

@vincepri vincepri Awaiting requested review from vincepri

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewmyhre @k8s-ci-robot @randomvariable