Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱[e2e] Install CNI using ClusterResourceSet and bump up CAPI to v0.3.9 #1816

Merged
merged 1 commit into from
Sep 10, 2020
Merged

🌱[e2e] Install CNI using ClusterResourceSet and bump up CAPI to v0.3.9 #1816

merged 1 commit into from
Sep 10, 2020

Conversation

sedefsavas
Copy link
Contributor

@sedefsavas sedefsavas commented Jul 13, 2020 •
edited by randomvariable
Loading

What this PR does / why we need it:
This PR installs e2e CNIs using ClusterResourceSet.

This PR should hold until CAPI changes are merged: kubernetes-sigs/cluster-api#3332

Fixes: #1929

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2020
@k8s-ci-robot k8s-ci-robot requested review from chuckha and ncdc July 13, 2020 20:36
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2020
randomvariable
randomvariable previously requested changes Jul 14, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@ncdc ncdc modified the milestones: v0.5.5, v0.5.x Jul 15, 2020
@randomvariable randomvariable dismissed their stale review July 15, 2020 18:38

Fixups in another PR

@randomvariable
Copy link
Member

Rebasing after #1823 should resolve the makefile issues. Intention is to merge after 0.5.5 @sedefsavas

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2020
@sedefsavas sedefsavas force-pushed the e2eCNICRS branch 2 times, most recently from 02e883b to 6500c0f Compare July 16, 2020 13:46
@sedefsavas
Copy link
Contributor Author

@randomvariable When is the expected date for v0.5.5?

@randomvariable
Copy link
Member

Very soon. Two PRs left at https://github.com/kubernetes-sigs/cluster-api-provider-aws/milestone/18

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2020
@sedefsavas sedefsavas mentioned this pull request Aug 6, 2020
Merged
@sedefsavas
Copy link
Contributor Author

/hold until CAPI v0.3.9 is released.

@ncdc
Copy link
Contributor

ncdc commented Aug 6, 2020

@sedefsavas FYI /hold has to be on its own line without any additional text after it (this was previously held because of the /hold in the description)

@randomvariable randomvariable changed the title 🌱[e2e] Install CNI using ClusterResourceSet 🌱[e2e] Install CNI using ClusterResourceSet (held for CAPI 0.3.9) Aug 11, 2020
@randomvariable randomvariable removed this from the v0.5.x milestone Aug 14, 2020
@randomvariable randomvariable added this to the v0.6.1 milestone Sep 2, 2020
This was referenced Sep 8, 2020
Merged
Closed
This was referenced Sep 8, 2020
Merged
Closed
@randomvariable
Copy link
Member

If we can rebase this, and bump CAPI to 0.3.9 in this PR, that'll probably be everything we need.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2020
@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-conformance

@sedefsavas
Copy link
Contributor Author

Changed capa-manager name as clusterctl requires canonical names in v0.3.9 release: kubernetes-sigs/cluster-api-provider-vsphere#1028

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-conformance

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-conformance

@sedefsavas sedefsavas changed the title 🌱[e2e] Install CNI using ClusterResourceSet (held for CAPI 0.3.9) 🌱[e2e] Install CNI using ClusterResourceSet and bump up CAPI to v0.3.9 Sep 9, 2020
@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@randomvariable
Copy link
Member

https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/1816/files#diff-a1c3266d5eb66f7451bcaefc7d050fdfL280 failing, but unclear why.

@sedefsavas
Copy link
Contributor Author

Yes, there is a problem with multiple workload clusters test, investigating.

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@sedefsavas
Copy link
Contributor Author

It was failing during deletion of a cluster, so maybe not a bug, this time it passes. Retesting.
/test pull-cluster-api-provider-aws-e2e

@randomvariable
Copy link
Member

It was failing during deletion of a cluster
in which case, #1887 should have resolved it.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit fc47a78 into kubernetes-sigs:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomvariable randomvariable randomvariable left review comments

@chuckha chuckha Awaiting requested review from chuckha

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.

e2e tests broken with CAPI 0.3.9
4 participants
@sedefsavas @randomvariable @ncdc @k8s-ci-robot