🐛 fix: bastion reconcilation and connection error when using eks flavor
#1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
richardcase
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Changing back to WIP to include other bastion related fixes |
richardcase
changed the title
richardcase
changed the title
k8s-ci-robot
added
size/L
|
I assume this will need to be rebased on #1949 |
Yes it will....thanks for approving the refactor. |
k8s-ci-robot
added
the
needs-rebase
The bastion was being reconciled before the security groups and this based the bastion reconciliation to fail. The reconciliation order has been updated.
A new security group has been added that will be added to node for a eks based cluster. This will allow adding additional ingress/egress rules over the ones defined by the EKS created security group.
k8s-ci-robot
removed
the
needs-rebase
richardcase
changed the title
eks flavor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The bastion was being reconciled before the security groups and this based the bastion reconciliation to fail. The reconciliation order has been updated.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1956
Fixes #1958