✨ Add support for DefaultCooldown to AWSMachinePool

[arghya88]

What this PR does / why we need it:

Add support for configuring cooldowns https://docs.aws.amazon.com/autoscaling/ec2/userguide/Cooldown.html to AWSMachinePool

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1987

[k8s-ci-robot]

Welcome @arghya88!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @arghya88. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[richardcase]

/ok-to-test

[arghya88]

/retest

[arghya88]

@randomvariable what do you think of this in it's current state? Let me know if any change is required like moving the defaulting to controller instead of relying on kubebuilder.

[richardcase]

Let me know if any change is required like moving the defaulting to controller instead of relying on kubebuilder.

Thanks @arghya88 . I think we need to add a validation check in the webhook to make sure that nothing crazy like a negative duration is specified and so we can fail early.

[arghya88]

@richardcase as I can see there is no webhook for AWSMachinePool but there is one for AWSManagedMachinePool. So we need to create a new webhook for AWSMachinePool because I added the DefaultCoolDown in AWSMachinePoolSpec not in AWSManagedMachinePoolSpec?

[richardcase]

Good point @arghya88....i'd missed that, sorry.

I think we should create the webhooks for AWSMachinePool and do this Duration check along with other validation checks for AWSMachinePool.

But perhaps we should create a separate issue for adding the webhooks for AWSMachinePool? What do you think @randomvariable ?

[arghya88]

@richardcase I am getting this error

Boilerplate header is wrong for: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/exp/api/v1alpha3/awsmachinepool_webhook.go
make: *** [Makefile:486: verify-boilerplate] Error 1

[richardcase]

I am getting this error

You will need to add the license header to the new webhook file. For example see this

[richardcase]

Any new files need to have the license comment in them.

[arghya88]

Any new files need to have the license comment in them.

Got it. Thanks for the guidance.

[arghya88]

/retest

[arghya88]

@randomvariable I have done below changes. PTAL

1. Made it optional
2. Setting default value in a webhook now
3. Validating negative value in the webhook

cc @richardcase

[arghya88]

/assign @davidewatson

[richardcase]

Seems ok to me

/lgtm

[randomvariable]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [randomvariable]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment