✨ Add tagging for AWSMachinePool resources #2021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, autoscaling groups, launch templates, and EC2 instances do not get the usual tags applied. This PR adds tagging with logic similar to that in the AWSMachine controller. We are running this code in our environment now, but it does still need tests written (We may get some time next week to work on that). I heard something about a tagging rework going on, so maybe this could benefit from that work. A better approach to this is definitely possible since it seemed when I started there was little code reuse around the tagging logic in the various controllers.