Refactor release process for Github and Staging #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
randomvariable
force-pushed
the
manifest-updates
branch
4 times, most recently
from
edd0193 to
51eeecf
Compare
|
This all looks good to me. Only thing I'd suggest is if possible are we able to break the Makefile down any more? It's becoming quite an intimidating file. |
sedefsavas
reviewed
Nov 9, 2020
sedefsavas
reviewed
Nov 9, 2020
randomvariable
force-pushed
the
manifest-updates
branch
3 times, most recently
from
8490f58 to
3460874
Compare
I think as a followup, probably start moving the make targets for each controller into their own directories. |
randomvariable
force-pushed
the
manifest-updates
branch
2 times, most recently
from
028253a to
9bff071
Compare
sedefsavas
reviewed
Nov 9, 2020
randomvariable
force-pushed
the
manifest-updates
branch
2 times, most recently
from
140745d to
c366dec
Compare
sedefsavas
reviewed
Nov 9, 2020
sedefsavas
reviewed
Nov 9, 2020
sedefsavas
reviewed
Nov 9, 2020
sedefsavas
reviewed
Nov 9, 2020
randomvariable
force-pushed
the
manifest-updates
branch
4 times, most recently
from
e670a6e to
1874655
Compare
|
@randomvariable Thanks for the sed change! CAPI would benefit from this too. This LGTM but do we want to include this in v0.6.2 release? |
|
@sedefsavas don't need it in v0.6.2 at this stage. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @ncdc tl;dr, finally stopped all the config files being rewritten. |
randomvariable
force-pushed
the
manifest-updates
branch
from
1874655 to
3e042a7
Compare
k8s-ci-robot
added
size/XL
randomvariable
force-pushed
the
manifest-updates
branch
from
3e042a7 to
a955017
Compare
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
the
needs-rebase
randomvariable
force-pushed
the
manifest-updates
branch
from
a955017 to
b6fa98e
Compare
k8s-ci-robot
removed
lgtm
Replace use of sed with gojq to modify templates, by copying manifests to _artifacts and outputting to out/*-components.yaml, preventing source files being modified in place. Switch to using Docker build cache to speed up builds, should reduce CloudBuild times significantly. CloudBuild modified such that manifests will be generated and uploaded to GCS on execution. This will allow advanced users to be able to test manifests directly from staging for testing prior to release. Finally, targets are added to create a release in Github using the Github CLI. Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
randomvariable
force-pushed
the
manifest-updates
branch
from
b6fa98e to
bebdfec
Compare
|
I've rebased this @richardcase |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of sed with gojq to modify templates, by copying manifests to _artifacts and outputting to out/*-components.yaml, preventing source files being modified in place.
Switch to using Docker build cache to speed up builds, which should reduce CloudBuild times significantly.
CloudBuild modified such that manifests will be generated and uploaded to GCS on execution. This will allow advanced users to be able to test manifests directly from staging for testing prior to release.
Finally, targets are added to create a release in Github using the Github CLI.
Signed-off-by: Naadir Jeewa jeewan@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #