-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update consuming-existing-aws-infrastructure.md to provide context to where networkSpec belongs #2103
Conversation
Provide context as to where the `networkSpec` is to be updated inside the `kind: AWSManagedControlPlane`
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @cdenneen! |
Hi @cdenneen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -34,6 +34,10 @@ Finally, if the controller manager isn't started with the `--configure-cloud-rou | |||
Specifying existing infrastructure for Cluster API to use takes place in the specification for the AWSCluster object. Specifically, you will need to add an entry with the VPC ID and the IDs of all applicable subnets into the `networkSpec` field. Here is an example: | |||
|
|||
```yaml | |||
apiVersion: controlplane.cluster.x-k8s.io/v1alpha3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For EKS based clusters it lives on AWSManagedControlPlane but for EC2 based clusters it lives on AWSCluster. For each of these kinds it is in the spec.
So i think we should we should either:
- Change this part
Specifying existing infrastructure for Cluster API to use takes place in the specification for the AWSCluster object
- Have a separate example or section for each cluster type
Provide examples for `AWSCluster` and `AWSManagedControlPlane` for context.
I signed it |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Provide context as to where the
networkSpec
is to be updated inside thekind: AWSManagedControlPlane