Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 awsmachinetemplates: Allow cloudInit.secureSecretsBackend to be defaulted #2111

Conversation

randomvariable
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2110

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2020
@randomvariable randomvariable changed the title awsmachinetemplates: Allow cloudInit.secureSecretsBackend to be defaulted 🐛 awsmachinetemplates: Allow cloudInit.secureSecretsBackend to be defaulted Nov 16, 2020
@sedefsavas
Copy link
Contributor

LGTM
Just have a question above.

…lted

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable randomvariable force-pushed the admission-controller-update branch from 64f70b4 to 20d737f Compare November 17, 2020 13:37
@sedefsavas
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2020
@randomvariable
Copy link
Member Author

/assign @ncdc

@ncdc
Copy link
Contributor

ncdc commented Nov 17, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit ec8626b into kubernetes-sigs:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWSMachineTemplate defaulting is being rejected by validation logic in the webhook
4 participants