-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Accept empty string SSHKeyName in AWSCluster & AWSMachine validation webhooks #2308
🐛 Accept empty string SSHKeyName in AWSCluster & AWSMachine validation webhooks #2308
Conversation
/lgtm |
thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry, a lint (gofmt) issue. Will fix and force-push. Ironically, it's complaining about a missing newline at the end of the file. Meanwhile, the same commit fixed the imports 😂 |
14dc07b
to
92eeda4
Compare
@randomvariable Thanks for the review! I hope this makes it into the next release 😄 |
/lgtm Also @dlipovetsky +1 to have a single set of tests. |
Thanks for the review @sedefsavas! |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Makes the AWSCluster & AWSMachine validation webhooks accept an empty string for
SSHKeyName
. That value is supported by the API.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2306
Special notes for your reviewer:
Checklist:
Release note: