-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test coverage #2350
Test coverage #2350
Conversation
go tool cover -func=out/coverage.out -o out/coverage.txt | ||
go tool cover -html=out/coverage.out -o out/coverage.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to go to $(ARTIFACTS) really, otherwise there's no information for the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's also a test coverage format that testgrid supports. Need to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing that wasn't working was getting gopherage to convert it to junit format. if there's a decent alternative, we should do that, as well as filtering out all the zz_generated stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added gopherage to the ci job: kubernetes/test-infra#21801
This is same with how CAPZ is doing, the coverage files are copied to the artifacts folder: https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/periodic-cluster-api-provider-azure-coverage/1382456816876654592/artifacts/
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds test coverage script which will be called periodically by test-infra.
kubernetes/test-infra#21801
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2144
Special notes for your reviewer:
Checklist:
Release note: