Issue 2358: Add required clustercontrolleridentities to eks rbac

[martin-ducar-gd]

What type of PR is this?
/kind bug

What this PR does / why we need it:

When using standard setup via clusterctl init

E0419 12:39:55.208006       1 reflector.go:153] pkg/mod/k8s.io/client-go@v0.17.9/tools/cache/reflector.go:105: Failed to list *v1alpha3.AWSClusterControllerIdentity: awsclustercontrolleridentities.infrastructure.cluster.x-k8s.io is forbidden: User "system:serviceaccount:capa-eks-control-plane-system:capa-eks-control-plane-controller-manager" cannot list resource "awsclustercontrolleridentities" in API group "infrastructure.cluster.x-k8s.io" at the cluster scope

Meaning new awsclustercontrolleridentities is not in the ClusterRole RBAC

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2358

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

Update RBAC with missing awsclustercontrolleridentities permission

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @martin-ducar-gd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[richardcase]

/ok-to-test

[richardcase]

@martin-ducar-gd - as you've changed the rbac declaration you'll need to run make generate

[martin-ducar-gd]

Thanks @richardcase executing, also trying to cleanup some old mess in linuxfoundation account to have CLA check pass

[martin-ducar-gd]

/test pull-cluster-api-provider-aws-verify

[richardcase]

@martin-ducar-gd - thanks for this change:

/lgtm

I'll approve when the CLA is sorted.

[richardcase]

We'll also need to apply this fix to main.

@randomvariable - would this be better to go into main and then release 0.6?

[martin-ducar-gd]

Let me know about the main part which to fix first

[randomvariable]

Yes, can you merge into main first, and then we'll cherry pick into release-0.6

[richardcase]

Yes, can you merge into main first, and then we'll cherry pick into release-0.6

@martin-ducar-gd - would you be able to change the target to main for this PR?

[richardcase]

/check-cla

[martin-ducar-gd]

/check-cla

[richardcase]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment