-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle LaunchTemplateNameNotFound error #2410
fix: handle LaunchTemplateNameNotFound error #2410
Conversation
I opened the PR against What about |
Thanks for the fix @dkoshkin. release-0.7 can be ignored as we don't have a v0.7.x release yet, all v1alpha4 changes are under main branch until we cut a release. |
Thank you for the quick response, will open a PR against |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-notfound-0.6 fix: handle LaunchTemplateNameNotFound error
What type of PR is this?
What this PR does / why we need it:
This function will return a
400
with an error likeInvalidLaunchTemplateName.NotFoundException: The specified launch template, with template name foo, does not exist.
cluster-api-provider-aws/pkg/cloud/services/ec2/launchtemplate.go
Line 77 in 7eb58f5
Added a new
LaunchTemplateNameNotFound
in theIsInvalidNotFoundError()
function and updated the unit tests to reflect what the AWS API returns.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2402
Special notes for your reviewer:
Also tested with a dev image
docker.io/dkoshkin/cluster-api-aws-controller-amd64:LaunchTemplateNameNotFound
Checklist:
Release note: