fix: Process extra statements for Cluster API Controllers

[Szymongib]

What type of PR is this?
/kind bug

What this PR does / why we need it:

This PR fixes the bug causing extraStatements section to be ignored for clusterAPIControllers when creating IAM role.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2387

Special notes for your reviewer:

Checklist:

• squashed commits
• adds unit tests

Release note:

Process extra statements for Cluster API Controllers

[k8s-ci-robot]

Hi @Szymongib. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sedefsavas]

We should not change the controllers.cluster-api-provider-aws.sigs.k8s.io here, instead similar to controlplane and node, we want to attach extra statemements as inline policy:

cluster-api-provider-aws/cmd/clusterawsadm/cloudformation/bootstrap/control_plane.go

Line 24 in 2a183f5

func (t Template) controlPlanePolicies() []cfn_iam.Role_Policy {

And add this as inline policy in the Policies section of the controller role.

[Szymongib]

Oh yea, that totally makes sense! Sorry about that, fixed.

[sedefsavas]

/ok-to-test

[richardcase]

/lgtm

[richardcase]

For final approval:

/assign sedefsavas

[sedefsavas]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sedefsavas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment