feat: add support for taints for managed machine pools (backport) #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XXL
|
Whilst additional testing: /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Is this also good to go @richardcase ? |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
The adds support for specifying taints on the AWSManagedMachinePool that will translate into taints being set on the nodes of the the EKS node group that is created. It also support updating the taints for a nodegroup. Signed-off-by: Richard Case <richard@weave.works>
Yes all good to go @sedefsavas |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
richardchen-db
pushed a commit
to databricks/cluster-api-provider-aws-1
that referenced
this pull request
Jan 14, 2023
…ints_06 feat: add support for taints for managed machine pools (backport)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds support for specifying taints on the
AWSManagedMachinePoolthat will translate into taints being set on the nodes of the the EKS node group that is created.It also supports updating the taints for a node group.
This is a backport of #2405
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Relates #2399
Special notes for your reviewer:
Checklist:
Release note: