Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI command added to list aws resources created by CAPA #2509

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

shivi28
Copy link
Contributor

@shivi28 shivi28 commented Jun 15, 2021

Usage:
clusterawsadm resource list [flags]

Eg: clusterawsadm resource list --cluster-name=<cluster name> --region=<region>

Output options: table(default), yaml, json

PARTITION   SERVICE                REGION       ACCOUNTID      RESOURCE                                 ARN
aws         ec2                    ap-south-1   832764931379   elastic-ip/eipalloc-0a4ef32fcffceaaf2    arn:aws:ec2:ap-south-1:832764931379:elastic-ip/eipalloc-0a4ef32fcffceaaf2
aws         ec2                    ap-south-1   832764931379   elastic-ip/eipalloc-04f393e86fd018583    arn:aws:ec2:ap-south-1:832764931379:elastic-ip/eipalloc-04f393e86fd018583
aws         ec2                    ap-south-1   832764931379   elastic-ip/eipalloc-0ef70b86d684b10a0    arn:aws:ec2:ap-south-1:832764931379:elastic-ip/eipalloc-0ef70b86d684b10a0
aws         ec2                    ap-south-1   832764931379   instance/i-07761eeeacb0692b0             arn:aws:ec2:ap-south-1:832764931379:instance/i-07761eeeacb0692b0
many more ...

What type of PR is this?
/kind feature

What this PR does / why we need it:
Introduce a CLI command to list AWS resources created by CAPA

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2381

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

CLI command to list AWS resources created by CAPA

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2021
@randomvariable
Copy link
Member

One issue with JSON and YAML output and if you could move the code around a bit, but otherwise great.
Thanks!

@shivi28 shivi28 force-pushed the aws_2381 branch 2 times, most recently from 7dfb8d8 to c159694 Compare June 17, 2021 16:22
@shivi28 shivi28 requested a review from richardcase June 17, 2021 16:34
@richardcase
Copy link
Member

@shivi28 - looking good. There is one minor typo i can see.

Usage:
clusterawsadm resource list [flags]

Eg: clusterawsadm resource list --cluster-name=<cluster name> --region=<region>

Output options: table(default), yaml, json
@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1dff4d6 into kubernetes-sigs:main Jun 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List AWS resources created by CAPA
4 participants