-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not delete overriden security groups #2555
Conversation
Pulled this in and tested; it's fixed on my end! - thanks again for a really quick turnaround! EDIT: Hang on, need to test again, but looks like we've still deleted all of the rules in the security groups (But not the SGs themselves) EDIT 2: Yep, confirmed. delete op on AWSCluster no longer deleting the SGs, but all of the rules in the provided security groups still get deleted. |
Thanks for checking, I will see what is going on. |
Found the issue, we were revoking the rules for all SGs. Now fixed. |
@sedefsavas: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm will sort out the e2e in post tomorrow |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority important-soon |
/kind bug
What this PR does / why we need it:
We were deleting SGs looking at
Status
, which also includes overridden SGs.Instead, during SG deletion, this PR only deletes the ones that have
sigs.k8s.io/cluster-api-provider-aws/cluster/name: owned
tag.Also, allows overriding SGs partially. Before all default SGs must have been overridden or seeing this error:
"msg"="failed to reconcile security groups" "error"="security group overrides have been provided for some but not all roles - missing security group for role bastion" "cluster"="tagleme" "name"="tagleme" "namespace"="default" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="AWSCluster"
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2548
Special notes for your reviewer:
Checklist:
Release note: