Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming spec.networkSpec to spec.network #2571

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Renaming spec.networkSpec to spec.network #2571

merged 1 commit into from
Jul 21, 2021

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Jul 8, 2021 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR renames the field networkSpec which seems redundant given that's already under spec, so we simplify it by changing it to network

Which issue(s) this PR fixes:
Fixes #2119

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Rename field `networkSpec` as `network`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Ankitasw. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2021
@randomvariable
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2021
@Ankitasw Ankitasw requested a review from randomvariable July 9, 2021 11:25
@Ankitasw
Copy link
Member Author

/retest

@randomvariable
Copy link
Member

Can you rebase on top of main and then rerun the test, it should work then.

@Ankitasw
Copy link
Member Author

/retest

@Ankitasw Ankitasw force-pushed the api-change branch 2 times, most recently from a7d4aca to c61f2da Compare July 18, 2021 11:51
@Ankitasw
Copy link
Member Author

/test

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-verify
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs:

  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-verify

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@randomvariable
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Jul 19, 2021
@randomvariable
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@Ankitasw
Copy link
Member Author

/lgtm
/approve

rebased the branch now

@Ankitasw Ankitasw force-pushed the api-change branch 5 times, most recently from 6c598dc to edd15ff Compare July 19, 2021 18:11
@randomvariable
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-blocking

@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 841195d into kubernetes-sigs:main Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone Jul 21, 2021
@Ankitasw Ankitasw deleted the api-change branch July 21, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

@sedefsavas sedefsavas Awaiting requested review from sedefsavas

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Consider renaming spec.networkSpec to spec.network
3 participants
@Ankitasw @k8s-ci-robot @randomvariable