Allow to configure garbage collector using clusterawsadm #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
Fedosin
force-pushed
the
gc_config_cli
branch
from
210f9ac to
3f9bd5b
Compare
|
@Fedosin since this is a feature request, it would be good to raise an issue first, and then go ahead with the PR. |
|
/approve cc @richardcase for another round of review. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR allows to configure garbage collector using clusterawsadm CLI tool. It adds new command
configuretoclusterawsadm gcthat will setExternalResourceGCAnnotationwith provided values on a specified cluster.Examples:
# Enable load-balancer and security-group tasks, target-group will be disabled. clusterawsadm gc configure --cluster-name=cluster --gc-task load-balancer --gc-task security-group# Reset configuration (remove the annotation) clusterawsadm gc configure --cluster-name=clusterWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4513
Special notes for your reviewer:
Checklist:
Release note: