Save Nat Gateways IPs to status on every reconciliation

[fiunchinho]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When we first create the nat gateways, they go to the Pending state. At that point, they don't have a PublicIP just yet. So if we only save the nat gateway public IP to the status field right after creating the nat gateway, we won't have the public IP available, meaning we won't be able to save it to the status.

Now the logic is changed so we always save the NAT Gateways IPs to the status field.

Special notes for your reviewer:

I've tested this version in our management clusters, adding our custom ingress rules and it all worked fine.

There was a missmatch in how the ingress rules were modeled in CAPA and the SDK, making the controller to keep reconciliating the same AWSCluster because the SecurityGroups saved in the field .status.networkStatus.securityGroups never matched the security groups returned by the AWS SDK. Now they match and no extra reconciliations are needed.

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

Fix how NAT gateways IPs are saved in the status field

[k8s-ci-robot]

Hi @fiunchinho. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AverageMarcus]

/ok-to-test

[AverageMarcus]

For consistency with the next line

Suggested change

	var natGatewaysIPs []string
	natGatewaysIPs := []string{}

[Skarlso]

Alternatively, the line could change to the var declaration. :)

[Skarlso]

Especially because it looks like it could be empty, so no need to pre-initialize it.

[fiunchinho]

Why is one way preferred over the other? Isn't it a empty slice in both cases?

[fiunchinho]

/test pull-cluster-api-provider-aws-e2e-eks

[Ankitasw]

/test pull-cluster-api-provider-aws-e2e

[Ankitasw]

@fiunchinho did you test locally to check the status field for NAT gateway IP?

[fiunchinho]

Yes, it's saving the IPs on the status field. But the controller is logging errors, because the ingress rules are being wrongly modified by a bug that it's fixed here #4359

[fiunchinho]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[fiunchinho]

/test pull-cluster-api-provider-aws-e2e

[k8s-ci-robot]

@fiunchinho: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-aws-e2e	c27e4fd	link	false	/test pull-cluster-api-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Ankitasw]

@fiunchinho we can ignore this test failure, it's not related to your change

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Ankitasw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[richardcase]

/cherrypick release-2.2

[k8s-infra-cherrypick-robot]

@richardcase: new pull request created: #4520

In response to this:

/cherrypick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.