Pass logger to machine pool scope to get verbosity right, fix copying logger in With... methods

[AndiDog]

What type of PR is this?

/kind bug

What this PR does / why we need it:

I found that not all of these logs were printed in production:

func (s *Service) ReconcileLaunchTemplate(
	scope scope.LaunchTemplateScope,
	ec2svc services.EC2Interface,
	canUpdateLaunchTemplate func() (bool, error),
	runPostLaunchTemplateUpdateOperation func() error,
) error {
	// [...]

	// <=== NOT PRINTED ===>
	scope.Info("checking for existing launch template")
	
	// [...]

	if needsUpdate || tagsChanged || amiChanged || userDataHashChanged || userDataSecretKeyChanged || launchTemplateNeedsUserDataSecretKeyTag {
		// <=== PRINTED ===>
		scope.Info("creating new version for launch template", "existing", launchTemplate, "incoming", scope.GetLaunchTemplate(), "needsUpdate", needsUpdate, "tagsChanged", tagsChanged, "amiChanged", amiChanged, "userDataHashChanged", userDataHashChanged, "userDataSecretKeyChanged", userDataSecretKeyChanged)
		
		// [...]
	}
	
	// [...]
}

That puzzled me a lot, given how both have the same verbosity. It turned out that the parent logger wasn't passed correctly to the MachinePoolScope. Also, WithName and other logger context functions mistakenly changed the object itself when using the Logger interface, as opposed to go-logr's behavior and interface documentation. With that, the deployed CAPA controller pod logged all desired lines in a reasonable format.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

n/a

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

Fix logging verbosity for machine pool reconciliation

[fiunchinho]

/lgtm

[richardcase]

/retest

[fiunchinho]

/retest

[richardcase]

/override pull-cluster-api-provider-aws-apidiff-main

[k8s-ci-robot]

@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-aws-apidiff-main

In response to this:

/override pull-cluster-api-provider-aws-apidiff-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[richardcase]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment