Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱ROSA Cleanup & Documentation #4665

Merged
merged 4 commits into from
Jan 5, 2024
Merged

🌱ROSA Cleanup & Documentation #4665

merged 4 commits into from
Jan 5, 2024

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Nov 28, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:
follow-up of #4453

This PR:

  • Introduce missing steps to deploy ROSA CRDs and enable ROSA controller when installing AWS provider.
  • Add documentation on how to enable ROSA support and create ROSA clusters using the AWS provider.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4428

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/documentation Categorizes issue or PR as related to documentation. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @muraee. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2023
@muraee muraee changed the title Rosa capi follow up ROSA Cleanup & Documentation Nov 28, 2023
@enxebre
Copy link
Member

enxebre commented Nov 29, 2023

/retitle 🌱ROSA Cleanup & Documentation
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot changed the title ROSA Cleanup & Documentation 🌱ROSA Cleanup & Documentation Nov 29, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 29, 2023
@muraee muraee force-pushed the rosa-capi-follow-up branch from 50c4575 to 51e821c Compare November 29, 2023 14:11
@enxebre
Copy link
Member

enxebre commented Nov 29, 2023

Thanks! Seems bot requires a release note
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 29, 2023
@enxebre enxebre mentioned this pull request Dec 12, 2023
Closed
5 tasks
@muraee muraee force-pushed the rosa-capi-follow-up branch from 51e821c to 095743e Compare January 2, 2024 16:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2024
@muraee muraee force-pushed the rosa-capi-follow-up branch from 095743e to f126e5a Compare January 2, 2024 16:06
@muraee muraee force-pushed the rosa-capi-follow-up branch from f126e5a to 4c788e8 Compare January 2, 2024 16:15
@muraee
Copy link
Contributor Author

muraee commented Jan 2, 2024

/retest-required

AndiDog
AndiDog reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one minor typo

docs/book/src/topics/rosa/index.md Outdated Show resolved Hide resolved
@muraee muraee force-pushed the rosa-capi-follow-up branch from 4c788e8 to aaf4294 Compare January 3, 2024 11:03
AndiDog
AndiDog reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2024
@muraee
Add docs for ROSA
4637126 
- add new cluster template for ROSA clusters
@muraee muraee force-pushed the rosa-capi-follow-up branch from aaf4294 to 4637126 Compare January 3, 2024 11:36
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2024
@muraee
Copy link
Contributor Author

muraee commented Jan 3, 2024

@AndiDog sorry I forgot to add a small change, could you retag it again please

AndiDog
AndiDog reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

but to fix the tests, we first need #4710 done.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2024
@muraee
Copy link
Contributor Author

muraee commented Jan 4, 2024

/retest-required

vincepri
vincepri approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit a6fe8ce into kubernetes-sigs:main Jan 5, 2024
17 checks passed
@muraee muraee mentioned this pull request Feb 8, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndiDog AndiDog AndiDog left review comments

@enxebre enxebre enxebre left review comments

@vincepri vincepri vincepri approved these changes

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

Assignees

@enxebre enxebre

@AndiDog AndiDog

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROSA: basic docs
5 participants
@muraee @k8s-ci-robot @enxebre @AndiDog @vincepri