Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ ROSA: Reconcile ROSAMachinePool version #4764

Merged
merged 3 commits into from
Feb 20, 2024
Merged

✨ ROSA: Reconcile ROSAMachinePool version #4764

merged 3 commits into from
Feb 20, 2024

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Jan 31, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
Validates and reconcile ROSAMachinePool.spec.version to trigger an upgrade if version changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add & Reconcile ROSAMachinePools.spec.version

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @muraee. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2024
@muraee muraee force-pushed the rosa-machinepool-version branch 3 times, most recently from 1da9d1e to 1e6a21e Compare February 1, 2024 15:04
stevekuznetsov
stevekuznetsov reviewed Feb 1, 2024
View reviewed changes
exp/controllers/rosamachinepool_controller.go Show resolved Hide resolved
pkg/rosa/nodepools.go Show resolved Hide resolved
pkg/rosa/versions.go Show resolved Hide resolved
pkg/rosa/versions.go
const versionPrefix = "openshift-v"

// RawVersionID returns the rawID from the provided OCM version object.
func RawVersionID(version *cmv1.Version) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simply import these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we agreed to not import the rosa cli repo, but work on creating a separate shared library?

Copy link
Contributor

@stevekuznetsov stevekuznetsov Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. We are importing the repo as it is - there are no changes needed and no migration to a common required.

exp/api/v1beta2/rosamachinepool_types.go Outdated Show resolved Hide resolved
@muraee muraee force-pushed the rosa-machinepool-version branch 2 times, most recently from a247f9d to bbd62ac Compare February 5, 2024 13:31
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2024
@muraee muraee force-pushed the rosa-machinepool-version branch 3 times, most recently from 8593961 to 721b83e Compare February 12, 2024 17:37
@muraee muraee force-pushed the rosa-machinepool-version branch from 721b83e to d5c8ce7 Compare February 13, 2024 09:59
vincepri
vincepri approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @stevekuznetsov

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@stevekuznetsov
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3cfa2a8 into kubernetes-sigs:main Feb 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@vincepri vincepri vincepri approved these changes

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@nrb nrb Awaiting requested review from nrb

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muraee @k8s-ci-robot @vincepri @stevekuznetsov