🐛 fix: additional control plane LBs must use correct schema/subnets

[mtulio]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Secondary control plane load balancer is created using same schema of primary, failing in some scenarios like primary is created as private (internal) and secondary external (internet-facing) - it will result in the external LB w/ private subnets.

Which issue(s) this PR fixes

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emojis
• adds unit tests
• adds or updates e2e tests

Release note:

Fix discovered subnets for additional Load Balancers ("SecondaryControlPlaneLoadBalancer") when it is internet-facing.

[k8s-ci-robot]

Hi @mtulio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtulio]

/test ?

[k8s-ci-robot]

@mtulio: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtulio]

/assign @vincepri

[mtulio]

Cluster installed successfully w/ second LB in the correct subnets (public). This PR is ready for review.

/cc @patrickdillon @vincepri @r4f4

[k8s-ci-robot]

@mtulio: GitHub didn't allow me to request PR reviews from the following users: patrickdillon, r4f4.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Cluster installed successfully w/ second LB in the correct subnets (public). This PR is ready for review.

/cc @patrickdillon @vincepri @r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[patrickdillon]

/assign @nrb

[nrb]

/ok-to-test
/lgtm

[nrb]

/retest

Unrelated infra errors

[vincepri]

/lgtm
/assign @nrb @richardcase

[mtulio]

@mtulio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-apidiff-main 6422b40 link false /test pull-cluster-api-provider-aws-apidiff-main

Ignoring the apidiff as it is informational.

[nrb]

/lgtm

[mtulio]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from richardcase.

@richardcase would you mind to taking a look at this PR?

[nrb]

Not sure why the needs-rebase label is still applied.

/tide refresh

[nrb]

/lgtm

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment