Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add non root volumes to AWSMachinePool #4954

Merged
merged 1 commit into from
Sep 3, 2024
Merged

✨ Add non root volumes to AWSMachinePool #4954

merged 1 commit into from
Sep 3, 2024

Conversation

mnitchev
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding non root volumes is already possible for the control-plane by specifying them in the AWSMachineTemplate, but only the RootVolume can be specified for AWSMachinePools. This PR adds this feature for the machine pools as well.

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add NonRootVolumes to AWSMachinePool launch template.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mnitchev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2024
@mnitchev mnitchev force-pushed the pr-non-root-volumes branch from 9e62acc to 8b12897 Compare April 25, 2024 04:08
cnmcavoy
cnmcavoy suggested changes Apr 25, 2024
View reviewed changes
pkg/cloud/services/ec2/launchtemplate.go Outdated
nonRootVolume := lt.NonRootVolumes[vi]

if nonRootVolume.DeviceName == "" {
return nil, errors.Errorf("non root volume should have device name specified")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation should be moved to the awsmachinepool_webhook.go. There's already logic in other webhooks to validate volumes, you should be able to re-use.

For example: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/2468/files#diff-d85ef380a29a05566d8f529b89c7746d5ce4b257400061fe52be4a9ef0647668R69-R95

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mnitchev mnitchev force-pushed the pr-non-root-volumes branch from 8b12897 to 39b0e05 Compare April 26, 2024 07:48
@richardcase
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2024
@mnitchev mnitchev force-pushed the pr-non-root-volumes branch from 39b0e05 to 1c956d2 Compare April 29, 2024 08:12
cnmcavoy
cnmcavoy approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@cnmcavoy cnmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2024
@mnitchev
Copy link
Contributor Author

@Ankitasw can you review please?

@AndiDog
Copy link
Contributor

AndiDog commented Aug 21, 2024

/lgtm
/test pull-cluster-api-provider-aws-e2e

Ready for approval if the E2E test runs fine.

@AndiDog
Copy link
Contributor

AndiDog commented Aug 23, 2024

/retest

@AndiDog
Copy link
Contributor

AndiDog commented Sep 3, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndiDog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit abe918c into kubernetes-sigs:main Sep 3, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnmcavoy cnmcavoy cnmcavoy approved these changes

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

Assignees

@AndiDog AndiDog

@cnmcavoy cnmcavoy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnitchev @k8s-ci-robot @richardcase @AndiDog @cnmcavoy